Add Outreachy mentor projects #938
Conversation
* upstream/master: Add .eslintrc to ensure that editor plugins will use the correct config (nodejs#928)
* upstream/master: outreachy: add myles' project add good first contributions to the outreachy page precede email addresses with mailto (nodejs#935) Translate "docs" menu as Korean (nodejs#904) nodejs-ja: Add about/index.md (nodejs#933) Revert "Blog: fix CVE ID for writeHead() bug / CVE-2016-5326" Blog: fix CVE ID for writeHead() bug / CVE-2016-5326 Add Education initiatives and Outreachy to Foundation section of website (nodejs#929)
|
+1 |
| </div> | ||
| </form> | ||
| </div> | ||
| <script type='text/javascript' src='//s3.amazonaws.com/downloads.mailchimp.com/js/mc-validate.js'></script><script type='text/javascript'>(function($) {window.fnames = new Array(); window.ftypes = new Array();fnames[0]='EMAIL';ftypes[0]='email';fnames[1]='FNAME';ftypes[1]='text';fnames[2]='LNAME';ftypes[2]='text';}(jQuery));var $mcj = jQuery.noConflict(true);</script> |
There was a problem hiding this comment.
The inline script will not work as the content is escaped when converted from markdown to html.
There was a problem hiding this comment.
Oh sorry, didn't notice it wasn't part of the actual change.
There was a problem hiding this comment.
HTML is valid markdown. So it shouldn't be escaped. (And it appears that it is not.)
There was a problem hiding this comment.
@Trott not an issue on this pr, but open https://nodejs.org/en/foundation/ and see the dev tools. Also see the generated HTML on #932.
There was a problem hiding this comment.
Ah, yes, the quotation marks are escaped and the other things noted in that issue. Thanks for pointing that out. I would say that's a bug in the processor and not in the markdown file, but either way, yeah, needs to be addressed.
|
LGTM |
|
LGTM |
5 participants
No description provided.