Merge io stream back in #135
Conversation
|
I'll help out reviewing this, will take a little bit though. |
There was a problem hiding this comment.
@dcousens the changes to this file is the meat of the update, most of the other changes are consequences of this
There was a problem hiding this comment.
great pains are made to make sure readableStream instanceof nativeStream is true, this avoids bundling the streams module unless it's already included.
In other words since you can't readableStream instanceof nativeStream without first doing var nativeStream = require('stream'); we only need to inherit from native streams if it's already bundled.
|
Lots of changes :) This is overall looking fine to me. 👍 @calvinmetcalf |
|
yes there are lots, though everything in the lib and test directory is auto generated |
|
based on #136 I'm leaning towards publishing this as v2.0.0 sometime tomorrow unless I hear objections |
|
updated with some changes to the readme to explain versioning and list the wg members, (do speak up if I missed you) |
|
Will review in the next 10 hours. If I don't ACK/comment by then, assume good to go and I'll post review. |
calvinmetcalf
force-pushed
the
merge-io-stream-back
branch
from
a298b7f to
91173c7
Compare
|
ok forced push to get the tests working |
|
@dcousens sorry I could only gave you 8 hours |
|
No worries @calvinmetcalf, I'll review post-haste. Sorry. |
|
LGTM |
merges the changes I made when publishing it as io-stream back in, contains the version of streams from node 2.2.1 tested to be working in node going back to v.0.8.
Outstanding issues include versioning, should this package be versioned to match the version of node/iojs it comes from or should it be versioned to independently?