-
-
Notifications
You must be signed in to change notification settings - Fork 130
doc: notes on purpose from WG meeting #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mhdawson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most of the content here might better go into a minutes doc under a meetings directory (ex https://github.com/nodejs/benchmarking/tree/master/meetings)
Have some specific comments inline as to what the content of the initial README.md might contain.
|
|
||
| *TODO* @jasnell, @mdawson What is process to "join" a Working Group. Is it PR an | ||
| addition of your name, email address, and github handle to this section of the | ||
| README if you want to be involved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far participation in WG has generally been, anybody interested can join. There are a few exceptions like the build WG where membership leads to access to machine etc and so the process of being formally added is a bit more rigorous. At this point I'd suggest we seed it with the list of interested parties from the issue and the make it a PR yourself into the group until we need something different.
| but don't know how, and do not want it in a public issue/PR on the modules | ||
| github repo. | ||
|
|
||
| Signed modules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is separate. I believe is a concept I'd discussed with James and the question was if this would be the right group to discuss bringing something like that in. In that context I don't think we need anything in the readme at this poin.
| done by the "security team", see https://github.com/nodejs/node#security | ||
|
|
||
| *todo*: should the team be identified in | ||
| https://github.com/nodejs/node#security? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd leave a decision on that until the group is up and running and we have a better feel as to what it is doing day to day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean the "security team", not the security working group. I might raise this as a bug on nodejs. Right now the security team is secret, I'm not sure that was intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sam-github Are you talking about https://github.com/orgs/nodejs/teams/security ? I think most of the teams in nodejs are private (i.e. you can't see who's in them unless you're a member of the nodejs org). I can see who's in that team.
If you meant that the security team list should be duplicated in the README, then fair enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that's the team. People reporting might want to know the identify of they are reporting vulns to, or maybe not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sam-github I think all the nodejs teams should be public (although maybe some might have a reason to be private).
| - Its possible there should be a community vulnerability response list, that | ||
| is available if people want to report a vulnerability in community modules, | ||
| but don't know how, and do not want it in a public issue/PR on the modules | ||
| github repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I'd suggest something which just captures the high level mandate of the working group (based on an existing example: https://github.com/nodejs/benchmarking)
Mandate
The Security working group's purpose is to achieve the highest level of security for Node.js and community modules.
Its responsibilities are:
- Work with the node security project to bring community vulnerability data into the foundation as
a shared asset - Set up processes and procedures and follow these to ensure the vulnerability data is updated in
an efficient and timely manner. As a example ensuring there are well documented processes
for reporting vulnerabilities in community modules. - Work to set a high standard for the Node.js project. Possibly efforts could include penetration
testing, security reviews etc, review guidelines, coding standards etc. - Review and recommend processes for handling of security reports (but not the implementation of those processes)_
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, see #9
|
|
||
|
|
||
| *TODO* Is there some boilerplate we need? Should we describe how meetings are | ||
| announced, for example? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the governance boilerplate, which includes CONTRIBUTING.md, GOVERNANCE.md they can likely just be copied from one of the other WGs or the TSC or CTC repo.
|
closing, going to move these into meeting notes, and PR the WG boilerplate |
No description provided.