Skip to content

Conversation

@tsctx
Copy link
Member

@tsctx tsctx commented Jan 8, 2024

Followup of #2507

isReadableAborted(body)
))
// TODO (fix): Why is body[kBodyUsed] needed?
return !!(body && (stream.isDisturbed(body) || body[kBodyUsed]))
Copy link
Member Author

@tsctx tsctx Jan 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

Attention: 170 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (5c25c00) 84.88%.
Report is 206 commits behind head on main.

Files Patch % Lines
lib/fetch/index.js 67.29% 52 Missing ⚠️
lib/fetch/util.js 37.17% 49 Missing ⚠️
lib/handler/RetryHandler.js 74.35% 30 Missing ⚠️
lib/core/diagnostics.js 84.74% 9 Missing ⚠️
lib/cache/cache.js 0.00% 6 Missing ⚠️
lib/api/readable.js 88.88% 5 Missing ⚠️
lib/fetch/headers.js 90.19% 5 Missing ⚠️
lib/client.js 93.54% 4 Missing ⚠️
lib/compat/dispatcher-weakref.js 57.14% 3 Missing ⚠️
lib/core/util.js 95.65% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2605      +/-   ##
==========================================
- Coverage   85.54%   84.88%   -0.67%     
==========================================
  Files          76       81       +5     
  Lines        6858     7279     +421     
==========================================
+ Hits         5867     6179     +312     
- Misses        991     1100     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tsctx tsctx force-pushed the refactor/version-cleanup branch from 964e7bf to a0bcdf2 Compare January 8, 2024 13:47
@mcollina mcollina merged commit 00f999d into nodejs:main Jan 8, 2024
@tsctx tsctx deleted the refactor/version-cleanup branch January 8, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants