-
-
Notifications
You must be signed in to change notification settings - Fork 686
refactor: version cleanup #2605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| isReadableAborted(body) | ||
| )) | ||
| // TODO (fix): Why is body[kBodyUsed] needed? | ||
| return !!(body && (stream.isDisturbed(body) || body[kBodyUsed])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API exists since v16.8.0.
https://nodejs.org/api/stream.html#streamreadableisdisturbedstream
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2605 +/- ##
==========================================
- Coverage 85.54% 84.88% -0.67%
==========================================
Files 76 81 +5
Lines 6858 7279 +421
==========================================
+ Hits 5867 6179 +312
- Misses 991 1100 +109 ☔ View full report in Codecov by Sentry. |
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
964e7bf to
a0bcdf2
Compare
Followup of #2507