-
-
Notifications
You must be signed in to change notification settings - Fork 685
fix: throw on keep-alive header #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this header understood by servers at all? I fear we are transferring bytes for no added benefits.. we'll lose some req/sec if this is not needed. Maybe behind an option?
(+1 with throwing anyway)
I have no idea. I might be interested in implementing it for Node core.
Unsure if the perf impact is even measurable. Wouldn't mind to put it behind an option if this is a concern. Suggestion for option name? |
|
Removing the send of header, keeping throw, opening issue in Node core to get feedback. |
From looking at nginx docs, it seems an header that is send from the server to the client. From http://nginx.org/en/docs/http/ngx_http_core_module.html
|
|
@mcollina Thanks! Let's implement it on our side then and adjust idleTimeout accordingly. |
|
👍 |
Provide a hint for the server to keep connection alive until it is
considered no longer re-usable by client. This reduces the risk of
a race where the client sends a request and the server closes it
before receiving it.
I don't think Node core uses this... but I guess it still could be useful.