-
-
Notifications
You must be signed in to change notification settings - Fork 688
feat(fetch): add zstandard decompression support #4238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Just saw your comment, thanks! I've amended the last commit to add two more test cases to match the ones for gzip and brotli:
|
KhafraDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests should be added to test/fetch; test/node-fetch is taken from node-fetch.
|
@KhafraDev I noticed the other encoding tests (like gzip and brotli) are in Would you prefer I move all of them into the |
|
@KhafraDev Ah, I see now, Thanks for the clarification. I’ll move the new test cases into the |
|
@KhafraDev I've moved the main test to |
bjohansebas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@KhafraDev I applied your suggestion |
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This relates to...
Closes #2847
Changes
lib/web/fetch/index.js: Added a condition inonHeadersto handle thezstdcontent-encoding header.test/fetch/encoding.js: Added a test case forzstddecompression.Features
Adds support for Zstandard (zstd) decompression in
fetch.Status