Skip to content

test: remove obsolete nodeMajor/nodeMinor util exports#4976

Merged
mcollina merged 1 commit intonodejs:mainfrom
trivikr:remove-node-major-minor-check
Apr 5, 2026
Merged

test: remove obsolete nodeMajor/nodeMinor util exports#4976
mcollina merged 1 commit intonodejs:mainfrom
trivikr:remove-node-major-minor-check

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented Apr 5, 2026

This relates to...

N/A

Rationale

Undici now supports Node.js >=22.19.0, so the exported nodeMajor/nodeMinor helpers are obsolete. The only remaining usage was a test-only branch for old console.table formatting behavior.

Changes

  • Remove nodeMajor and nodeMinor from lib/core/util.js
  • Simplify test/mock-interceptor-unused-assertions.js to assume the Node 22+ console.table layout
  • Drop the now-unused util import and version-gated snapshot branches from that test

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (ad6b0c6) to head (d40e218).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4976      +/-   ##
==========================================
- Coverage   92.94%   92.94%   -0.01%     
==========================================
  Files         110      110              
  Lines       35771    35767       -4     
==========================================
- Hits        33248    33244       -4     
  Misses       2523     2523              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6a30f74 into nodejs:main Apr 5, 2026
35 checks passed
@trivikr trivikr deleted the remove-node-major-minor-check branch April 5, 2026 18:59
@github-actions github-actions bot mentioned this pull request Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants