Merged
Conversation
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5005 +/- ##
=======================================
Coverage 92.92% 92.92%
=======================================
Files 110 110
Lines 35729 35735 +6
=======================================
+ Hits 33201 33208 +7
+ Misses 2528 2527 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #3969
Rationale
The test was timing out intermittently when run under full suite pressure (
npm run test:unit) because it relied on a fixed 500ms wall-clock sleep rather than synchronizing on actual async operations. The test was blindly hoping that the sleep time would settle all the internal state, but under stress pressure, that assumption breaks. Additionally, theRetryAgentwas never explicitly closed, potentially causing resource leaks or stale state between tests in the suite.Changes
await sleep(500)to eliminate the wall-clock wait that masked timing racesafter()hook for proper cleanupawait agent.close()in teardown to ensureRetryAgentresources are explicitly releasedFeatures
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
Status