Skip to content

Conversation

@mcollina
Copy link
Member

I have seen the close of my processes being severely delayed by this.
I'm not sure how to test this though.

@mcollina mcollina requested a review from ronag July 22, 2021 16:49
@ronag
Copy link
Member

ronag commented Jul 22, 2021

I'm surprised the client-unref test doesn't catch this? Maybe that could be improved?

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

Merging #896 (bf5681c) into main (0391411) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   99.57%   99.48%   -0.10%     
==========================================
  Files          26       26              
  Lines        2131     2132       +1     
==========================================
- Hits         2122     2121       -1     
- Misses          9       11       +2     
Impacted Files Coverage Δ
lib/core/connect.js 100.00% <100.00%> (ø)
lib/client.js 99.34% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0391411...bf5681c. Read the comment docs.

@mcollina mcollina changed the title unref() connectTimeout always clear the connectTimeout Jul 22, 2021
@mcollina
Copy link
Member Author

@ronag I've updated this.

@mcollina mcollina merged commit d6f0fcf into main Jul 22, 2021
@mcollina mcollina deleted the unref-connectTimeout branch July 22, 2021 18:06
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* unref() connectTimeout

* clear out the connect timeout in all cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants