Merged
Conversation
RafaelGSS
commented
Feb 27, 2024
| let server = undefined; | ||
| if (settings.type === 'http') { | ||
| server = spawnServer(settings); | ||
| // TODO: replace this workaround to use IPC to know when server is up |
Member
Author
There was a problem hiding this comment.
edsadr
requested changes
Feb 27, 2024
Member
edsadr
left a comment
edsadr
left a comment
There was a problem hiding this comment.
just few nits there to get us a good start and maybe add some more to the README
edsadr
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the initial framework template. The idea is to open other PRs including benchmarks of other modules. Once we have a reasonable amount of reports, we'll store it in a JSON file to be displayed in some UI.
Currently, two types of benchmark will be supported:
For the former, I'm going to use
benchmark.jsfor now, but my plan is to work on https://github.com/RafaelGSS/bench-node as part of the work of migrating it into Node.js core.The repository is designed to be used as a source of comparison across releases. The package versions will be fixed and upgraded every 6 months to prevent misleading comparisons due to changes.