src,feat: add new packages and support to worker threads#3
Merged
Conversation
HTTP benchmarks are non-deterministc and until we adapt this framework to perform more than one benchmark for each type: 'http' I would not consider its results as valid or reliable.
It doesn't seem to make sense to benchmark it in a Node.js|NS runtime.
santigimeno
approved these changes
Mar 6, 2024
Member
santigimeno
left a comment
santigimeno
left a comment
There was a problem hiding this comment.
Looks good. What's the reasoning for running the benchmarks in workers, isolation?
Comment on lines
+23
to
+48
| // { | ||
| // name: 'format (singleQuote=true semi=true tabs=true)', | ||
| // fn: () => { | ||
| // let v = undefined; | ||
| // for (const p of payloads) { | ||
| // v = prettier.format( | ||
| // p, | ||
| // { singleQuote: true, semi: true, tabs: true, parser: 'babel' }, | ||
| // ); | ||
| // } | ||
| // return v; | ||
| // }, | ||
| // }, | ||
| // { | ||
| // name: 'format (singleQuote=false semi=false tabs=false)', | ||
| // fn: () => { | ||
| // let v = undefined; | ||
| // for (const p of payloads) { | ||
| // v = prettier.format( | ||
| // p, | ||
| // { singleQuote: false, semi: false, tabs: false, parser: 'babel' } | ||
| // ); | ||
| // } | ||
| // return v; | ||
| // }, | ||
| // }, |
Member
There was a problem hiding this comment.
Is this commented for a reason?
Member
Author
There was a problem hiding this comment.
I think you commented on an outdated version somehow. It's now uncommented.
Member
Author
Yes, guarantee a benchmark won't affect other benchmarks (inline cache and so on) |
edsadr
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.