src: fix thread-safety issues @ ContinuousProfiler#309
Closed
santigimeno wants to merge 1 commit intonode-v22.x-nsolid-v5.xfrom
Closed
src: fix thread-safety issues @ ContinuousProfiler#309santigimeno wants to merge 1 commit intonode-v22.x-nsolid-v5.xfrom
santigimeno wants to merge 1 commit intonode-v22.x-nsolid-v5.xfrom
Conversation
WalkthroughThe changes refactor the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ContinuousProfiler
participant Thread
User->>ContinuousProfiler: Enable(interval_ms)
ContinuousProfiler->>ContinuousProfiler: Acquire lock, set enabled_
ContinuousProfiler->>ContinuousProfiler: Check should_start()
alt should_start() true
ContinuousProfiler->>ContinuousProfiler: start_cpu_profiling()
end
User->>ContinuousProfiler: register_hook_impl(callback)
ContinuousProfiler->>ContinuousProfiler: Acquire lock, add callback
ContinuousProfiler->>ContinuousProfiler: Check should_start()
alt should_start() true
ContinuousProfiler->>ContinuousProfiler: start_cpu_profiling()
end
User->>ContinuousProfiler: Disable()
ContinuousProfiler->>ContinuousProfiler: Acquire lock, set enabled_ = false
User->>ContinuousProfiler: UnregisterHook(hook_id)
ContinuousProfiler->>ContinuousProfiler: Acquire lock, remove callback
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (9)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Other comments: 0 Blocking, 0 Optional, 0 Nit, 2 FYI
- FYI: src/nsolid/continuous_profiler.cc (71-71) FYI: The code uses `should_start()` method in several places (lines 61, 71, 90) but this method isn't defined in the visible code. Make sure this method is properly implemented.
- FYI: src/nsolid/continuous_profiler.cc (171-171) FYI: The `pending_threads_.erase(thread_id)` call is already protected by the `thread_mutex_` lock at the beginning of the `on_thread_removed()` method. No need for additional locking here.
| uv_loop_t* loop_ = nullptr; | ||
| uint64_t interval_ = 60000; // Default: 1 minute per configuration | ||
| std::atomic<uint64_t> interval_ = 60000; // 1 min | ||
| bool enabled_ = false; // Disabled by default per config |
There was a problem hiding this comment.
The enabled_ member variable should be declared as std::atomic<bool> for thread safety, similar to how interval_ was changed to std::atomic<uint64_t>.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
santigimeno
force-pushed
the
santi/continuous_profiling_thread_safety
branch
from
7da3c8c to
adce98e
Compare
santigimeno
force-pushed
the
santi/continuous_profiling_thread_safety
branch
from
adce98e to
e43a523
Compare
Member
Author
RafaelGSS
approved these changes
Jun 4, 2025
santigimeno
added a commit
that referenced
this pull request
Jun 5, 2025
Fixes: nodesource/nsolid-roadmap#31 PR-URL: #309 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Member
Author
|
Landed in 63ce33e |
santigimeno
added a commit
that referenced
this pull request
Aug 25, 2025
Fixes: nodesource/nsolid-roadmap#31 PR-URL: #309 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
santigimeno
added a commit
that referenced
this pull request
Aug 26, 2025
Fixes: nodesource/nsolid-roadmap#31 PR-URL: #309 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> PR-URL: #359 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit