Skip to content

agents: fix crash in StatsDAgent#32

Merged
santigimeno merged 1 commit intonode-v20.x-nsolid-v5.xfrom
santi/fix_crash_peername
Dec 1, 2023
Merged

agents: fix crash in StatsDAgent#32
santigimeno merged 1 commit intonode-v20.x-nsolid-v5.xfrom
santi/fix_crash_peername

Conversation

@santigimeno
Copy link
Copy Markdown
Member

With some specific udp send errors, it's not possible to retrieve the peername. Handle this case to avoid crashes.

Fixes: #31

@santigimeno santigimeno self-assigned this Nov 23, 2023
@trevnorris trevnorris force-pushed the node-v20.x-nsolid-v5.x branch from 1a1236e to b2c1bb3 Compare November 30, 2023 23:47
With some specific udp send errors, it's not possible to retrieve the
peername. Handle this case to avoid crashes.

Fixes: #31
PR-URL: #32
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
@santigimeno santigimeno force-pushed the santi/fix_crash_peername branch from cf1a376 to 5a47d7e Compare December 1, 2023 10:21
@santigimeno santigimeno merged commit 5a47d7e into node-v20.x-nsolid-v5.x Dec 1, 2023
@santigimeno santigimeno deleted the santi/fix_crash_peername branch December 1, 2023 10:24
santigimeno added a commit that referenced this pull request Dec 6, 2023
With some specific udp send errors, it's not possible to retrieve the
peername. Handle this case to avoid crashes.

Fixes: #31
PR-URL: #32
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
trevnorris pushed a commit that referenced this pull request Dec 7, 2023
With some specific udp send errors, it's not possible to retrieve the
peername. Handle this case to avoid crashes.

Fixes: #31
PR-URL: #32
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash on StatsDAgent on resource-constrained box with load

2 participants