agents: enable compression in GrpcAgent by santigimeno · Pull Request #346 · nodesource/nsolid

santigimeno · 2025-07-23T08:54:58Z

Summary by CodeRabbit

New Features
- Enabled gzip compression for all OTLP gRPC communications, improving data transfer efficiency for traces, metrics, and logs.

coderabbitai · 2025-07-23T08:55:04Z

Walkthrough

The update adds gzip compression to all OTLP gRPC communications configured by the agent. This is achieved by setting the compression field to "gzip" in the client and exporter option objects within the GrpcAgent::config method. No other logic, error handling, or public interfaces are affected.

Changes

Cohort / File(s)	Change Summary
Enable gzip compression in OTLP gRPC options `agents/grpc/src/grpc_agent.cc`	Sets `compression` to `"gzip"` for OTLP gRPC client and all exporter option objects in `GrpcAgent::config`. No other logic or interface changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop and a skip, a packet zipped tight,
Gzip now travels with data in flight.
The agent’s new trick—compression so neat—
Makes OTLP gRPC streams light on their feet.
With every small change, we rabbits delight! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f9e9b16 and 3363fbd.

📒 Files selected for processing (1)

agents/grpc/src/grpc_agent.cc (4 hunks)

✅ Files skipped from review due to trivial changes (1)

agents/grpc/src/grpc_agent.cc

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

GitHub Check: coverage-windows
GitHub Check: lint-js-and-md
GitHub Check: test-linux (ubuntu-24.04)
GitHub Check: test-linux (ubuntu-24.04-arm)
GitHub Check: build-tarball
GitHub Check: test-macOS
GitHub Check: build-docs

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch santi/enable_compression

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

agents/grpc/src/grpc_agent.cc (1)
1048-1048: Avoid copy-pasting the magic literal "gzip" four times

The same compression value is assigned to every OTLP option struct. This is easy to miss when further exporters are added and slightly clutters the diff.
-      opts.compression = "gzip";
+      constexpr char kGrpcCompression[] = "gzip";
+      opts.compression = kGrpcCompression;
...
-        options.compression = "gzip";
+        options.compression = kGrpcCompression;
...
-        options.compression = "gzip";
+        options.compression = kGrpcCompression;
...
-        options.compression = "gzip";
+        options.compression = kGrpcCompression;
(Or wrap the common initialisation in a small helper that fills all the shared fields.)

No functional change, but it improves maintainability and keeps future edits in one place.

Also applies to: 1074-1074, 1091-1091, 1109-1109

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 580c207 and 90bf424.

📒 Files selected for processing (1)

agents/grpc/src/grpc_agent.cc (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

GitHub Check: lint-js-and-md
GitHub Check: coverage-windows
GitHub Check: test-linux (ubuntu-24.04-arm)
GitHub Check: test-linux (ubuntu-24.04)
GitHub Check: build-docs
GitHub Check: build-tarball
GitHub Check: test-macOS

🔇 Additional comments (1)

agents/grpc/src/grpc_agent.cc (1)

1048-1049: Verified correct use of compression field

The vendored OtlpGrpcClientOptions struct in
deps/opentelemetry-cpp/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client_options.h
(lines 58–60) defines:

std::string compression;

Assigning opts.compression = "gzip"; will correctly enable gzip compression at runtime. No changes needed.

juanarbol

LGTM

RafaelGSS

Do we have tests for it?

PR-URL: #346 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

santigimeno · 2025-08-20T08:24:57Z

Landed in 01455a7

PR-URL: #346 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: #346 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> PR-URL: #359

PR-URL: #346 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

santigimeno requested review from RafaelGSS and juanarbol July 23, 2025 08:54

santigimeno self-assigned this Jul 23, 2025

coderabbitai Bot reviewed Jul 23, 2025

View reviewed changes

coderabbitai Bot approved these changes Jul 23, 2025

View reviewed changes

santigimeno force-pushed the node-v22.x-nsolid-v5.x branch from 580c207 to b22a61c Compare July 23, 2025 15:32

santigimeno force-pushed the santi/enable_compression branch from 90bf424 to dbc0aaa Compare July 23, 2025 15:36

agents: enable compression in GrpcAgent

3363fbd

santigimeno force-pushed the santi/enable_compression branch from f9e9b16 to 3363fbd Compare August 6, 2025 14:03

juanarbol approved these changes Aug 19, 2025

View reviewed changes

RafaelGSS approved these changes Aug 19, 2025

View reviewed changes

santigimeno added a commit that referenced this pull request Aug 20, 2025

agents: enable compression in GrpcAgent

01455a7

PR-URL: #346 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

santigimeno closed this Aug 20, 2025

santigimeno deleted the santi/enable_compression branch August 20, 2025 08:25

santigimeno added a commit that referenced this pull request Aug 25, 2025

agents: enable compression in GrpcAgent

7d36db6

PR-URL: #346 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

santigimeno added a commit that referenced this pull request Aug 26, 2025

agents: enable compression in GrpcAgent

6fe5981

PR-URL: #346 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> PR-URL: #359

santigimeno added a commit that referenced this pull request Mar 12, 2026

agents: enable compression in GrpcAgent

8596d3e

PR-URL: #346 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

agents: enable compression in GrpcAgent#346

agents: enable compression in GrpcAgent#346
santigimeno wants to merge 1 commit intonode-v22.x-nsolid-v5.xfrom
santi/enable_compression

santigimeno commented Jul 23, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 23, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Uh oh!

juanarbol left a comment

Uh oh!

RafaelGSS left a comment

Uh oh!

santigimeno commented Aug 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

santigimeno commented Jul 23, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

juanarbol left a comment

Choose a reason for hiding this comment

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

santigimeno commented Aug 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

santigimeno commented Jul 23, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)