Skip to content

2025-09-17, Version 22.18.0-nsolid-v6.0.1 'Jod'#365

Merged
santigimeno merged 1 commit intonode-v22.x-nsolid-v5.xfrom
node-v22.18.0-nsolid-v6.0.1-release
Sep 23, 2025
Merged

2025-09-17, Version 22.18.0-nsolid-v6.0.1 'Jod'#365
santigimeno merged 1 commit intonode-v22.x-nsolid-v5.xfrom
node-v22.18.0-nsolid-v6.0.1-release

Conversation

@santigimeno
Copy link
Copy Markdown
Member

@santigimeno santigimeno commented Sep 17, 2025

Summary by CodeRabbit

  • Documentation
    • Added new changelog entry for 2025-09-17, Version 22.18.0-nsolid-v6.0.1 “Jod,” summarizing recent improvements to process metrics handling.
  • Chores
    • Updated versioning to mark this as a release build; version strings no longer include the “-pre” suffix.

@santigimeno santigimeno self-assigned this Sep 17, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 17, 2025

Walkthrough

Adds a new changelog entry for 2025-09-17 documenting two metrics-related commits and flips NSOLID_VERSION_IS_RELEASE to 1 in src/node_version.h, removing the "-pre" tag from version strings to mark a release build.

Changes

Cohort / File(s) Summary of changes
Changelog update
doc/changelogs/NSOLID_CHANGELOG_V5_NODE_V22.md
Added top-level entry for 2025-09-17 (22.18.0-nsolid-v6.0.1 'Jod') noting commits: allow missing process title in metrics update; handle nameless user in ProcessMetrics::Update. No other edits.
Release flag and tagging
src/node_version.h
Set NSOLID_VERSION_IS_RELEASE from 0 to 1, making NSOLID_TAG empty and removing "-pre" suffix from NSOLID_VERSION_STRING/NSOLID_EXE_VERSION for release build.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • juanarbol
  • RafaelGSS

Poem

I thump the ground—release day cheer,
The “-pre” hops off, the tags are clear.
Changelogs nibble tidy rows,
Metrics learn what process knows.
Ears up high, I stamp and say:
Version’s ripe—ship it today! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "2025-09-17, Version 22.18.0-nsolid-v6.0.1 'Jod'" is concise and directly describes the primary change (a release/version bump and changelog entry for 22.18.0-nsolid-v6.0.1), which matches the PR objectives and the modified files (changelog and version macro).
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch node-v22.18.0-nsolid-v6.0.1-release

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae1497d and be6e306.

📒 Files selected for processing (2)
  • doc/changelogs/NSOLID_CHANGELOG_V5_NODE_V22.md (1 hunks)
  • src/node_version.h (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: test-linux (ubuntu-24.04-arm)
  • GitHub Check: coverage-windows
  • GitHub Check: test-linux (ubuntu-24.04)
  • GitHub Check: lint-js-and-md
  • GitHub Check: build-tarball
  • GitHub Check: test-macOS
🔇 Additional comments (2)
doc/changelogs/NSOLID_CHANGELOG_V5_NODE_V22.md (1)

5-11: Changelog entry looks correct — verification failed

Automated check returned "Missing expected commits in PR #364". Confirm that commits ae1497d and bd5af31 are included in PR #364 and that tag v22.18.0-nsolid-v6.0.1 will be created.

src/node_version.h (1)

39-39: Approve release flip — set NSOLID_VERSION_IS_RELEASE = 1 for v6.0.1

Verified: repo search shows NSOLID_TAG/NSOLID_VERSION_STRING usage is limited to src/node_version.h and referenced from src/node_metadata.{h,cc} (plus docs/tests); no other code assumes a "-pre" suffix.

Follow-ups:

  • Confirm packaging/installer metadata paths (src/node_metadata.h) handle an empty NSOLID_TAG (no "-pre").
  • After tagging, commit patch+1 to set NSOLID_VERSION_IS_RELEASE back to 0.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Comment @coderabbitai help to get the list of available commands and usage tips.

@santigimeno santigimeno merged commit be6e306 into node-v22.x-nsolid-v5.x Sep 23, 2025
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants