Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// README at: https://github.com/devcontainers/templates/tree/main/src/javascript-node-postgres
{
"name": "Node Vault",
"image": "mcr.microsoft.com/devcontainers/javascript-node:0-18",
"image": "mcr.microsoft.com/devcontainers/javascript-node:1-18-bookworm",
"workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
// Features to add to the dev container. More info: https://containers.dev/features.
// "features": {},
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/lint-and-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
# Use node 16
# Use node 18
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: Install dependencies
# Install deps from lockfile
run: npm ci
Expand All @@ -29,7 +29,8 @@ jobs:
strategy:
matrix:
# We verify compatibility for current and previous LTS
node_version: [16, 18]
# Jun 2025 -> Still supporting node 16 tho it was EOL on September 11, 2023
node_version: [16, 18, 20, 22, 23, 24]
name: "[ Node ${{ matrix.node_version }} ] Run tests and push to codecov"
env:
NODE_VERSION: ${{ matrix.node_version }}
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ SHELL ["/bin/bash", "--login", "-c"]
RUN apt update && apt install -y curl
# Get optional env var to set node version
ARG SET_NODE_VERSION
# Set default to node 16.20.0
ENV NODE_VERSION ${SET_NODE_VERSION:-16.20.0}
# Set default to node 18.20.8
ENV NODE_VERSION ${SET_NODE_VERSION:-18.20.8}
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | bash
RUN nvm install $NODE_VERSION

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"docs": "docco --output docs src/*.js"
},
"engines": {
"node": ">= 16.0.0"
"node": ">= 18.0.0"
},
"directories": {
"example": "./example",
Expand Down
Loading