Skip to content

fix: Resolve type checking errors and update CI/CD workflow (v0.7.1)#29

Merged
djm81 merged 12 commits intomainfrom
dev
Nov 22, 2025
Merged

fix: Resolve type checking errors and update CI/CD workflow (v0.7.1)#29
djm81 merged 12 commits intomainfrom
dev

Conversation

@djm81
Copy link
Copy Markdown
Collaborator

@djm81 djm81 commented Nov 22, 2025

Summary

This PR includes:

  • Fixed 71 type checking errors (reportCallIssue) by adding missing contracts=None and clarifications=None parameters
  • Fixed beartype forward reference issues with StructuredFormat by using typing.Optional instead of union syntax
  • Updated CI/CD workflow to fail on type checking errors instead of just warning
  • Updated version to 0.7.1 across all relevant files

Changes

Type Checking Fixes

  • Added missing contracts=None to Story constructors in test files
  • Added missing clarifications=None to PlanBundle constructors in test files
  • Fixed StructuredFormat forward reference issues in structured_io.py and command files

CI/CD Improvements

  • Updated .github/workflows/pr-orchestrator.yml to fail on type checking errors
  • Removed fallback that allowed type errors to pass

Version Update

  • Updated version to 0.7.1 in pyproject.toml, setup.py, and __init__.py files

Testing

All tests pass:

  • ✅ All 71 type checking errors resolved
  • ✅ All beartype forward reference issues fixed
  • ✅ All previously failing tests now pass

Related

  • Fixes CI/CD type checking failures
  • Resolves beartype runtime errors in tests

cursoragent and others added 12 commits November 18, 2025 13:31
Co-authored-by: dominikus.nold <dominikus.nold@web.de>
- Add --batch-updates option to plan update-feature command
- Add --batch-updates option to plan update-story command
- Add --list-findings option to plan review command with structured output
- Refactor review function to reduce complexity
- Add comprehensive e2e tests for batch updates
- Update documentation and prompts to prefer batch updates
- Update version to 0.7.0
…itioning

- Updated all examples and guides with CLI-first messaging
- Added Integration Showcases references throughout documentation
- Emphasized integration diversity (VS Code, Cursor, GitHub Actions, pre-commit)
- Updated brownfield showcase examples with integration workflow sections
- Updated platform-frontend CMS to link to Integration Showcases README
- Reviewed and aligned all brownfield documentation for CLI-first approach
- Updated version to 0.7.1

Files updated:
- All docs/examples/ files (6 files)
- All docs/guides/ files (6 files)
- docs/reference/directory-structure.md
- platform-frontend/iac/scripts/payload-content-helper.js
- Version files: pyproject.toml, setup.py, src/__init__.py, src/specfact_cli/__init__.py
- CHANGELOG.md with comprehensive 0.7.1 entry
- Fixed basedpyright warnings for repo_path.exists() in contract decorators
- Added isinstance() type guard to properly narrow Path | None types
- Updated Example 3 validation status to FULLY VALIDATED (CI/CD workflow verified in production)
- Updated documentation to reflect Example 3 is validated in specfact-cli repository CI/CD

Fixes type checking errors reported in GitHub Actions workflow:
- constitution_evidence_extractor.py:65:53 - Type of "exists" is unknown
- Fixed in all three methods: extract_article_vii_evidence, extract_article_viii_evidence, extract_article_ix_evidence

Example 3 Status Update:
- Changed from "COMMANDS VERIFIED" to "FULLY VALIDATED"
- Validated in production CI/CD (specfact-cli PR #28)
- Workflow successfully runs specfact repro and blocks PRs when validation fails
@djm81 djm81 merged commit 5d9c90f into main Nov 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants