Conversation
Co-authored-by: dominikus.nold <dominikus.nold@web.de>
- Add --batch-updates option to plan update-feature command - Add --batch-updates option to plan update-story command - Add --list-findings option to plan review command with structured output - Refactor review function to reduce complexity - Add comprehensive e2e tests for batch updates - Update documentation and prompts to prefer batch updates - Update version to 0.7.0
…itioning - Updated all examples and guides with CLI-first messaging - Added Integration Showcases references throughout documentation - Emphasized integration diversity (VS Code, Cursor, GitHub Actions, pre-commit) - Updated brownfield showcase examples with integration workflow sections - Updated platform-frontend CMS to link to Integration Showcases README - Reviewed and aligned all brownfield documentation for CLI-first approach - Updated version to 0.7.1 Files updated: - All docs/examples/ files (6 files) - All docs/guides/ files (6 files) - docs/reference/directory-structure.md - platform-frontend/iac/scripts/payload-content-helper.js - Version files: pyproject.toml, setup.py, src/__init__.py, src/specfact_cli/__init__.py - CHANGELOG.md with comprehensive 0.7.1 entry
- Fixed basedpyright warnings for repo_path.exists() in contract decorators - Added isinstance() type guard to properly narrow Path | None types - Updated Example 3 validation status to FULLY VALIDATED (CI/CD workflow verified in production) - Updated documentation to reflect Example 3 is validated in specfact-cli repository CI/CD Fixes type checking errors reported in GitHub Actions workflow: - constitution_evidence_extractor.py:65:53 - Type of "exists" is unknown - Fixed in all three methods: extract_article_vii_evidence, extract_article_viii_evidence, extract_article_ix_evidence Example 3 Status Update: - Changed from "COMMANDS VERIFIED" to "FULLY VALIDATED" - Validated in production CI/CD (specfact-cli PR #28) - Workflow successfully runs specfact repro and blocks PRs when validation fails
- Add contract density validator (contract_validator.py) with metrics calculation - Integrate contract density into enforce sdd and plan review commands - Add contract density metrics display in plan review output - Fix plan bundle hash persistence in plan harden command - Add integration test for plan bundle hash persistence - Update version to 0.8.0 - Update CHANGELOG.md with Phase 4 completion details - Update end-user documentation with new commands (plan harden, enforce sdd, generate contracts) Phase 4 Status: ✅ COMPLETE (2025-11-24) - 4.1 Contract Stub Generator: ✅ Complete - 4.2 Contract Density Scoring: ✅ Complete (10 unit tests passing) Test Coverage: - 10 unit tests for contract density validation - 1 integration test for hash persistence - All tests passing
Contributor
SpecFact CLI Validation Report✅ All validations passed! |
Contributor
SpecFact CLI Validation Report✅ All validations passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4: Contract Generation from SDD - ✅ COMPLETE
This PR completes Phase 4 of the SDD Feature Parity Implementation Plan, adding contract generation and density scoring capabilities.
🎯 What's New
Contract Density Scoring
src/specfact_cli/validators/contract_validator.pyContractDensityMetricsclass for tracking contract density metricscalculate_contract_density()function calculates contracts per story, invariants per feature, and architecture facetsvalidate_contract_density()function validates metrics against SDD coverage thresholdsspecfact enforce sddandspecfact plan reviewcommandsplan reviewoutput when SDD manifest is presentBug Fixes
plan hardencalculated hash but didn't save plan bundle to diskspecfact generate contractsafterplan hardentest_plan_harden_persists_hash_to_diskto prevent regression📚 Documentation Updates
docs/reference/commands.mdwith:plan hardencommand documentationenforce sddcommand documentation with contract density validationgenerate contractscommand documentationplan reviewdocumentation🧪 Testing
test_plan_hardensuite with hash persistence verification📦 Version
✅ Phase 4 Status
🔗 Related