-
Notifications
You must be signed in to change notification settings - Fork 1
docs(openspec): finalize module-migration-05 tracking after modules PR merge #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d87636b
Implement blockers to prepare for module-migration-03 change.
djm81 b6b3be3
Merge branch 'feature/module-migration-05-modules-repo-quality' of ht…
djm81 504310e
Update migration change
djm81 bcfc66f
docs(openspec): close migration-05 PR tracking and change order
djm81 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
...ec/changes/module-migration-05-modules-repo-quality/DOCS_MIGRATION_INVENTORY.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # Docs Migration Inventory | ||
|
|
||
| Date: 2026-03-04 | ||
|
|
||
| ## Source docs identified in `specfact-cli` | ||
|
|
||
| ### Bundle and module oriented guides | ||
|
|
||
| - `docs/guides/marketplace.md` | ||
| - `docs/guides/import-features.md` | ||
| - `docs/guides/backlog-refinement.md` | ||
| - `docs/guides/backlog-dependency-analysis.md` | ||
| - `docs/guides/backlog-delta-commands.md` | ||
| - `docs/guides/project-devops-flow.md` | ||
| - `docs/guides/policy-engine-commands.md` | ||
| - `docs/guides/sidecar-validation.md` | ||
| - `docs/getting-started/module-bootstrap-checklist.md` | ||
|
|
||
| ### Module command/reference docs | ||
|
|
||
| - `docs/reference/commands.md` | ||
| - `docs/reference/module-categories.md` | ||
| - `docs/reference/module-contracts.md` | ||
| - `docs/reference/module-security.md` | ||
|
|
||
| ## Migrated target in `specfact-cli-modules` | ||
|
|
||
| - `docs/guides/` (copied from `specfact-cli/docs/guides/`) | ||
| - `docs/getting-started/` (copied from `specfact-cli/docs/getting-started/`) | ||
| - `docs/reference/` (copied from `specfact-cli/docs/reference/`) | ||
| - `docs/adapters/` (copied from `specfact-cli/docs/adapters/`) | ||
| - Jekyll baseline: `docs/_config.yml`, `docs/_layouts/default.html`, `docs/assets/main.scss`, `docs/index.md` | ||
|
|
||
| ## Cross-link updates in `specfact-cli` | ||
|
|
||
| - `README.md` module marketplace section now links to: | ||
| - `https://nold-ai.github.io/specfact-cli-modules/` | ||
| - `docs/index.md` module marketplace section now links to: | ||
| - `https://nold-ai.github.io/specfact-cli-modules/` |
33 changes: 33 additions & 0 deletions
33
...hanges/module-migration-05-modules-repo-quality/MODULE_GROUP_BOUNDARY_REPORT.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Module Group Boundary Report | ||
|
|
||
| Date: 2026-03-04 | ||
|
|
||
| ## Scope | ||
|
|
||
| - Change: `module-migration-05-modules-repo-quality` | ||
| - Repository: `specfact-cli-modules` | ||
| - Validation target: Section 19.4 (dependency decoupling and boundary enforcement) | ||
|
|
||
| ## Results | ||
|
|
||
| - `scripts/check-bundle-imports.py`: **pass** | ||
| - Remaining `from specfact_cli.* import` statements are CORE/SHARED only. | ||
| - No forbidden MIGRATE-tier `specfact_cli.*` imports remain in `packages/**`. | ||
| - No direct cross-bundle lateral imports are present in current source scan. | ||
|
|
||
| ## Allowed cross-bundle routes (policy) | ||
|
|
||
| - `specfact_spec` -> `specfact_project` | ||
| - `specfact_govern` -> `specfact_project` | ||
|
|
||
| ## Observed cross-bundle imports in current code | ||
|
|
||
| - None | ||
|
|
||
| ## Notes | ||
|
|
||
| - Import gate is now wired into: | ||
| - `hatch run check-bundle-imports` | ||
| - `.pre-commit-config.yaml` (`check-bundle-imports` hook) | ||
| - `.github/workflows/quality-gates.yml` (`Bundle Import Boundary Check` step) | ||
| - This report pairs with `ALLOWED_IMPORTS.md` and `scripts/check-bundle-imports.py` in `specfact-cli-modules`. |
29 changes: 29 additions & 0 deletions
29
openspec/changes/module-migration-05-modules-repo-quality/RESIDUAL_FAILURES.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Residual Failures and Handoff (module-migration-05) | ||
|
|
||
| Date: 2026-03-04 | ||
|
|
||
| ## Scope of this residual list | ||
|
|
||
| This list captures items that are either: | ||
| - not bundle-scope defects inside `specfact-cli-modules`, or | ||
| - not executable from this environment (remote GitHub operations), | ||
| after local bundle test migration parity was validated (`hatch run smart-test` passed). | ||
|
|
||
| ## Residual items | ||
|
|
||
| 1. Remote branch protection + PR validation for `specfact-cli-modules` | ||
| - Why residual: requires live GitHub API/PR operations (`21.3`, `21.5`) not reachable from this environment (`api.github.com` connectivity failure). | ||
| - Follow-up path: execute once network/GitHub access is available from maintainer environment. | ||
|
|
||
| 2. Remaining import-path decoupling work (MIGRATE-tier moves) | ||
| - Why residual: tracked in section `19.2+`; not part of the completed baseline test migration checks. | ||
| - Follow-up OpenSpec change: `module-migration-06-core-decoupling-cleanup` (#338). | ||
|
|
||
| 3. Residual specfact-cli legacy test cleanup outside bundle-scope parity | ||
| - Why residual: explicitly out of scope for migration-05 acceptance once modules-repo parity handoff is complete. | ||
| - Follow-up OpenSpec change: `module-migration-07-test-migration-cleanup` (#339). | ||
|
|
||
| ## Acceptance boundary | ||
|
|
||
| `module-migration-05` acceptance remains focused on modules-repo quality parity and migration handoff. | ||
| Unrelated legacy `specfact-cli` suite debt is tracked in the follow-up changes above and should not block this change's parity-focused closure. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This residual entry says branch-protection and PR validation could not be executed due to
api.github.comconnectivity, but the same commit records those steps as completed intasks.md(branch protection applied in 21.3 and PR checks merged in PR.2). Leaving this contradiction in a closure artifact can cause duplicate follow-up work or incorrect handoff status because readers cannot tell whether these operational gates are actually done.Useful? React with 👍 / 👎.