Skip to content

fix(scripts): CliRunner compat without mix_stderr (Click 8.3+) #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djm81 merged 1 commit into from
Mar 26, 2026
Merged

fix(scripts): CliRunner compat without mix_stderr (Click 8.3+) #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/check-docs-commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,15 +143,16 @@ def validate_command_tokens(tokens: list[str]) -> tuple[bool, str]:
if not tokens:
return True, ""

runner = CliRunner(mix_stderr=False)
runner = CliRunner()
last_err = ""
for k in range(len(tokens), 0, -1):
prefix = tokens[:k]
result = runner.invoke(app, [*prefix, "--help"], catch_exceptions=True)
exc = getattr(result, "exception", None)
if result.exit_code == 0 and exc is None:
return True, ""
err = (result.stderr or result.stdout or getattr(result, "output", None) or "").strip()
# CliRunner default merges stderr into stdout; ``result.stderr`` raises if not split.
err = (result.stdout or "").strip()
if exc is not None:
last_err = f"{type(exc).__name__}: {exc!s}"[:800]
else:
Expand Down
Loading