Skip to content

fix: assert hook id stability and cd to repo root for local actionlint #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djm81 merged 1 commit into from
Mar 30, 2026
Merged

fix: assert hook id stability and cd to repo root for local actionlint #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/run_actionlint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ has_docker() {
}

if has_actionlint; then
cd "$REPO_ROOT"
actionlint -no-color
exit $?
fi
Expand Down
1 change: 1 addition & 0 deletions tests/unit/workflows/test_trustworthy_green_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ def test_pre_commit_config_installs_supported_smart_check_wrapper() -> None:
matching = [hook for hook in hooks if hook.get("entry") == "scripts/pre-commit-smart-checks.sh"]
assert matching, "Expected .pre-commit-config.yaml to expose the smart-check wrapper hook"
hook = matching[0]
assert hook.get("id") == "specfact-smart-checks", "Hook id must remain stable for pre-commit consumers"
assert hook.get("pass_filenames") is False
assert hook.get("language") == "script"

Expand Down
Loading