fix: CodeRabbit review remediations for release 0.46.0#499
fix: CodeRabbit review remediations for release 0.46.0#499djm81 merged 3 commits intochore/release-0.46.0from
Conversation
Scope-aware JSON I/O gate, ADO source_tracking list handling, GitHub remote url regex, Speckit acceptance fallback, theme import matching, async pattern scan simplification, doc frontmatter title from canonical id, changelog Unreleased header, tests and shallow-modules-repo guard. Co-authored-by: Dom <djm81@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b17fff5c11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…ct_writes) Visit positional and kw-only defaults before applying parameter shadow scopes so defaults are checked in the enclosing namespace. Add regression tests for loads() in defaults. Co-authored-by: Dom <djm81@users.noreply.github.com>
Co-authored-by: Dom <djm81@users.noreply.github.com>
2 participants
Summary
Addresses the valid CodeRabbit / inline review items discussed for
chore/release-0.46.0: doc frontmatter title derivation, scope-aware JSON I/O gate + parse error handling, ADO source-tracking consolidation and empty-list handling, GitHuburlvspushurldetection, SpecKit acceptance fallback, import theme token matching, async-pattern scan simplification, OpenSpec parser test assertions, deterministicverify_safe_project_writestests, graph analyzer Google-style docstring, andCHANGELOGUnreleased header.Also fixes integration test collection when
REPO_ROOT.parents[2]is unavailable (shallow checkout layout).Testing
hatch run format,hatch run type-check,hatch run contract-testhatch teston modified unit test modules (verify_safe_project_writes, github, openspec_parser, speckit, code_analyzer, ado)hatch testin this environment: 2370 passed, 19 skipped, 13 failed (missing optional modules / signing / external tooling — unrelated to this diff)Notes
modules/bundle-mapper/module-package.yamlintegrity fields — no artifact build/sign pipeline in this agent run; release workflow should still validate checksum/signature at publish time.Base branch:
chore/release-0.46.0(merge this PR there, then into the release PR as needed).