ARM: fix incorrect variable names#14
Merged
Merged
Conversation
The ARM SHA256 functions take the state variables in simple alphabetic order, ABCD and EFGH. Documented [here](https://developer.arm.com/architectures/instruction-sets/intrinsics/#f:@navigationhierarchiesinstructiongroup=[Cryptography,SHA256]) The state is ordered and use correctly only the names are wrong. So no calculations are changed.
|
agreed, I ran into the same confusion when reading the ARM code |
noloader
approved these changes
Jan 7, 2026
jrakibi
added a commit
to jrakibi/bitcoin
that referenced
this pull request
May 3, 2026
…HA-256 ARM intrinsics ARM SHA256 intrinsics take state in natural order: ABCD + EFGH (hash_abcd/hash_efgh). The code already uses that layout, only the ABEF_SAVE/CDGH_SAVE names were wrong. Rename to ABCD_SAVE/EFGH_SAVE. No logic change. Docs: https://developer.arm.com/architectures/instruction-sets/intrinsics/#f:@navigationhierarchiesinstructiongroup=[Cryptography,SHA256] Fix in original C code (Jeffrey): noloader/SHA-Intrinsics#14 -BEGIN VERIFY SCRIPT- perl -pi -e 's/\bABEF_SAVE([AB])?\b/ABCD_SAVE$1/g' src/crypto/sha256_arm_shani.cpp perl -pi -e 's/\bCDGH_SAVE([AB])?\b/EFGH_SAVE$1/g' src/crypto/sha256_arm_shani.cpp -END VERIFY SCRIPT-
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ARM SHA256 functions take the state variables in simple alphabetic order, ABCD and EFGH. Documented here.
The state is ordered and use correctly only the names are wrong. So no calculations are changed.