Feat:Support shell-like command#186
Merged
yanyongyu merged 21 commits intononebot:devfrom Feb 2, 2021
AkiraXie:master
Merged
Conversation
Plugin: 模拟抽卡
Plugin: nonebot-plugin-wordbank
Plugin: 冷却事件
Plugin: mqtt接入
Plugin: 消息交互式 python 解释器
Plugin: songpicker2
Plugin: 风格化字符串管理
mnixry
reviewed
Feb 1, 2021
| import asyncio | ||
| from itertools import product | ||
| from typing import Any, Dict, Union, Tuple, Optional, Callable, NoReturn, Awaitable, TYPE_CHECKING | ||
| from loguru import logger |
Member
There was a problem hiding this comment.
这里的logger是不是应该从nonebot.log引? 而且我好像也没看到要用到logger的地方
| try: | ||
| args = shell_like_argsparser.parse_args( | ||
| strip_message.split()) | ||
| state["args"]=dict() |
Member
There was a problem hiding this comment.
没有看明白为什么这里要拆成两行
state["args"] = {**args.__dict__} # 或者 args.__dict__.copy()这样不行嘛
另外这一行是不是没格式化(
yanyongyu
approved these changes
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #185