src/CMakeLists.txt: fix TERMIT_CFLAGS

[Rongronggg9]

LUA_INCLUDE_DIR is incorrect, the correct one is LUA_INCLUDEDIR. Thus, "-I${LUA_INCLUDE_DIR}" will become "-I", suppressing the following argument. However, it can be simply dropped as d9731f1 has already included LUA_CFLAGS in TERMIT_CFLAGS.

Close #125

Built successfully on Arch Linux (mips64r6el, QEMU user) (previously failed): https://oss.cipunited.com/ci/job/ciBuilds/job/termit/42/execution/node/57/log/

Also built successfully on Arch Linux and Debian sid (both x86_64) in my local tests.

Detailed analysis here: #125 (comment)

[nonstop]

Thanks a lot

[Rongronggg9]

Sorry for disturbing you, @nonstop. Why was the PR closed? Did I make any mistakes?

termit/src/CMakeLists.txt

Lines 28 to 41 in 41978d9

	SET(LUA_VERSION "" CACHE STRING "Lua version")
	IF(LUA_VERSION STREQUAL "")
	IF(${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD")
	pkg_search_module(LUA REQUIRED lua53)
	ELSE(${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD")
	pkg_search_module(LUA REQUIRED lua>=5.3 lua5.3)
	ENDIF(${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD")
	ELSE(LUA_VERSION STREQUAL "")
	pkg_search_module(LUA REQUIRED
	lua=${LUA_VERSION} lua5.3=${LUA_VERSION})
	ENDIF(LUA_VERSION STREQUAL "")
	IF(NOT LUA_FOUND)
	message(FATAL_ERROR "Lua library was not found.")
	ENDIF(NOT LUA_FOUND)

The method used to find Lua is pkg_check_modules which belongs to the module FindPkgConfig. According to https://cmake.org/cmake/help/v3.24/module/FindPkgConfig.html, LUA_INCLUDE_DIR is incorrect, but LUA_INCLUDEDIR.

LUA_INCLUDE_DIR is correct only if the method used to find Lua is find_package(LUA) belonging to module FindLua, but the reality is the opposite.

---

The reason why I simply dropped the whole flag is that LUA_CFLAGS is already here (it always includes -I${LUA_INCLUDEDIR} if needed):

termit/src/CMakeLists.txt

Line 49 in 41978d9

FOREACH(cflag ${VTE_CFLAGS} ${GTK_CFLAGS} ${LUA_CFLAGS})

And what's more, according to my analysis here, due to the "coincidence" on Debian, -I -pthread becomes a useless flag, de facto the same as dropping them completely.

[nonstop]

I thought I merged your pull request.

[nonstop]

Oh, yeah!