-
Notifications
You must be signed in to change notification settings - Fork 8
Description
I've realized different things with the logging of statusengine cakephp application
-
The LegacyShell Daemon uses a hardcoded file handler to write the output to
-
The current hardcoded file handler logging doesn't log any timestamps in the logfile which makes it harder to analyse future possible problems or crashes.
-
The current code doesn't support logfile rotation. StatusengineLegacyShell.php could reopen (close/open) the logfile on SIGHUP or similar to support log rotation.
-
CakePHP provides a generic LogHandlerInterface which supports file, syslog and other handler. Is there a reason for not using the generic logging interface instead of fopen/fwrite? With generic logging and syslog you would tackle the logrotation problem also since logrotation can be taken care on the syslog server, etc