allow SpotlightDialog person search on non-matrix attributes

[4www]

Follow-up on the PR and discussion here: matrix-org#9556

[HarHarLinks]

should probably keep this:

Suggested change

	const members = findVisibleRoomMembers(cli);
	const members = findVisibleRoomMembers(cli, msc3946ProcessDynamicPredecessor);

[HarHarLinks]

this test case is not clear: with this, searching by location would require searching for (a substring of) Earth, which is also a substring of earthling and Earth Person. That means it would also match in the current implementation. However with our change, the dialogue should be able to successfully find a user such as

            user_id: "@earthling:matrix.org",
            display_name: "Earth Person",
            avatar_url: undefined,
            location: "Mars",

with a query of Mars.

[HarHarLinks]

it seems superfluous to not just do

Suggested change

	const results = users.filter(
	(it) => {
	return (
	!searchTerm ||
	it.user_id.toLowerCase().includes(searchTerm) ||
	it.display_name?.toLowerCase().includes(searchTerm) ||
	it.location?.toLowerCase().includes(searchTerm)
	)
	}
	);
	const results = users;

while this illustrates how the server works, i feel it overcomplicates things without being useful in this place. unless i'm overlooking something?