fix: add tsa cert chain revocation check after timestamping#246
Merged
9 commits merged intomainfrom Nov 29, 2024
unknown repository
Merged
fix: add tsa cert chain revocation check after timestamping#2469 commits merged intomainfrom unknown repository
9 commits merged intomainfrom
unknown repository
Conversation
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
ghost
requested review from
JeyJeyGao,
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 91.79% 92.02% +0.23%
==========================================
Files 30 31 +1
Lines 2607 2645 +38
==========================================
+ Hits 2393 2434 +41
+ Misses 163 161 -2
+ Partials 51 50 -1 ☔ View full report in Codecov by Sentry. |
JeyJeyGao
reviewed
Nov 21, 2024
shizhMSFT
reviewed
Nov 21, 2024
added 5 commits
November 25, 2024 15:59
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to enable tsa certificate chain revocation check after timestamping during signing.
Resolves #237