Skip to content

feat: support CRUD on TrustPolicy#132

Merged
binbin-li merged 4 commits intonotaryproject:dev-rc.1from
binbin-li:support-policy-crud
Sep 27, 2022
Merged

feat: support CRUD on TrustPolicy#132
binbin-li merged 4 commits intonotaryproject:dev-rc.1from
binbin-li:support-policy-crud

Conversation

@binbin-li
Copy link
Contributor

@binbin-li binbin-li commented Sep 8, 2022

What?

Defined and implemented functions to support CRUD on the policy file.
This PR just adds the basic support. We'll need another PR to refactor it to integrate with the current config read/write module.

Test?

Did manually tests with PR: notaryproject/notation#333. Will add unit tests in another PR.

Signed-off-by: Binbin Li libinbin@microsoft.com

@binbin-li binbin-li changed the title [WIP] feat: support CRUD on TrustPolicy feat: support CRUD on TrustPolicy Sep 13, 2022
Copy link
Contributor

@chloeyin chloeyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT added the dev Issue or PR related to dev branches label Sep 21, 2022
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
@binbin-li binbin-li merged commit 9522304 into notaryproject:dev-rc.1 Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev Issue or PR related to dev branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments