Skip to content

Comments

Fix VerifySignature command json marshaling#188

Merged
priteshbandi merged 2 commits intonotaryproject:mainfrom
rgnote:bug-fix
Nov 9, 2022
Merged

Fix VerifySignature command json marshaling#188
priteshbandi merged 2 commits intonotaryproject:mainfrom
rgnote:bug-fix

Conversation

@rgnote
Copy link
Contributor

@rgnote rgnote commented Nov 8, 2022

Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #188 (9f0110f) into main (a44d663) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   80.76%   80.78%   +0.01%     
==========================================
  Files          22       22              
  Lines        1716     1717       +1     
==========================================
+ Hits         1386     1387       +1     
  Misses        258      258              
  Partials       72       72              
Impacted Files Coverage Δ
plugin/plugin.go 0.00% <ø> (ø)
verification/verifier_helpers.go 68.96% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 49ba3a3 into notaryproject:main Nov 9, 2022
@rgnote rgnote deleted the bug-fix branch November 9, 2022 03:50
@rgnote rgnote restored the bug-fix branch November 9, 2022 03:50
patrickzheng200 pushed a commit to patrickzheng200/notation-go that referenced this pull request Nov 12, 2022
Temporary fix for
notaryproject/notation-core-go#88

Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants