Update: added ErrorPushSignatureFailed#271
Merged
priteshbandi merged 2 commits intonotaryproject:mainfrom Feb 7, 2023
Merged
Conversation
added 2 commits
February 7, 2023 16:13
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #271 +/- ##
==========================================
- Coverage 73.72% 73.53% -0.20%
==========================================
Files 23 23
Lines 1918 1923 +5
==========================================
Hits 1414 1414
- Misses 405 410 +5
Partials 99 99
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
ErrorPushSignatureFailederror type so that users of notation.Sign() would be able to check error type on Signing failures.On notation CLI side, if the error is of type
ErrorPushSignatureFailed, a suggestion of using OCI image manifest will be printed out.