Merged
Conversation
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
ghost
requested review from
JeyJeyGao,
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #452 +/- ##
============================================
Coverage 81.34% 81.34%
============================================
Files 32 32
Lines 2283 2283
============================================
Hits 1857 1857
Misses 298 298
Partials 128 128 ☔ View full report in Codecov by Sentry. |
Author
|
LGTM |
Contributor
|
LGTM |
priteshbandi
approved these changes
Sep 5, 2024
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release
This would mean tagging e6dde2d as
v1.2.1to release.Vote
We need at least
4approvals from6maintainers to releasenotation-go v1.2.1.What's Changed
Full Changelog:
v1.2.0...e6dde2d
Actions
Please review the PR and vote by approving.