Skip to content

Comments

feat: crl cache#462

Merged
30 commits merged intomainfrom
unknown repository
Sep 26, 2024
Merged

feat: crl cache#462
30 commits merged intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Sep 20, 2024

This PR adds an implementation of CRL cache along with {NOTATION_CACHE} directory for callers to initialize the cache.

Patrick Zheng added 3 commits September 20, 2024 16:14
crl
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 90.69767% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.34%. Comparing base (9faa6e2) to head (8df277a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/file/file.go 53.84% 3 Missing and 3 partials ⚠️
verifier/crl/crl.go 96.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   81.01%   81.34%   +0.32%     
==========================================
  Files          33       34       +1     
  Lines        2492     2578      +86     
==========================================
+ Hits         2019     2097      +78     
- Misses        331      335       +4     
- Partials      142      146       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Patrick Zheng added 3 commits September 21, 2024 19:29
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested a review from shizhMSFT September 23, 2024 03:04
Patrick Zheng added 2 commits September 23, 2024 11:23
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 2 commits September 23, 2024 16:00
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested a review from shizhMSFT September 23, 2024 08:07
Patrick Zheng added 2 commits September 23, 2024 16:15
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 5 commits September 23, 2024 17:05
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
fix
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 2 commits September 24, 2024 08:17
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
log
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 3 commits September 24, 2024 14:46
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested review from priteshbandi and shizhMSFT September 24, 2024 07:11
Patrick Zheng added 2 commits September 24, 2024 15:47
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 2 commits September 25, 2024 10:38
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested a review from shizhMSFT September 25, 2024 03:03
Patrick Zheng added 2 commits September 25, 2024 11:24
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 84c2ec0 into notaryproject:main Sep 26, 2024
@ghost ghost deleted the crl branch September 26, 2024 02:00
@ghost ghost mentioned this pull request Sep 27, 2024
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants