refactor!: remove blob sign/verify for v1.3.0-rc.1 release#464
Merged
3 commits merged intorelease-1.3from Sep 27, 2024
unknown repository
Merged
refactor!: remove blob sign/verify for v1.3.0-rc.1 release#4643 commits merged intorelease-1.3from unknown repository
3 commits merged intorelease-1.3from
unknown repository
Conversation
added 2 commits
September 26, 2024 10:36
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
ghost
requested review from
JeyJeyGao,
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.3 #464 +/- ##
===============================================
+ Coverage 81.34% 81.71% +0.37%
===============================================
Files 34 33 -1
Lines 2578 2374 -204
===============================================
- Hits 2097 1940 -157
+ Misses 335 302 -33
+ Partials 146 132 -14 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
ghost
mentioned this pull request
Contributor
|
Other maintainers may take a look at https://github.com/notaryproject/notation-go/compare/v1.2.1..b9e098b21ddbd1f0426a094458e9e7bf5a434d75 for faster review. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for
release-1.3branch.It removes the blob sign/verify from this version. The commit is cherry picked from what we had in v1.2.