chore: Improve error message in case of plugin timeout#472
Merged
priteshbandi merged 7 commits intonotaryproject:mainfrom Nov 14, 2024
Merged
chore: Improve error message in case of plugin timeout#472priteshbandi merged 7 commits intonotaryproject:mainfrom
priteshbandi merged 7 commits intonotaryproject:mainfrom
Conversation
priteshbandi
requested review from
JeyJeyGao,
NiazFK,
gokarnm,
rgnote,
shizhMSFT and
toddysm
as code owners
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
+ Coverage 80.25% 80.33% +0.07%
==========================================
Files 34 34
Lines 3318 3320 +2
==========================================
+ Hits 2663 2667 +4
+ Misses 509 508 -1
+ Partials 146 145 -1 ☔ View full report in Codecov by Sentry. |
rgnote
reviewed
Oct 31, 2024
ghost
reviewed
Nov 1, 2024
|
@priteshbandi The PR needs a rebase. |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a plugin exceeds the specified timeout or deadline for content processing, the current error message displayed is
signal: killed.This PR updates the error message to a more informative message:
[plugin_name] [command_name] command execution timeout: signal: killed