perf(log): encode objects only when logged#481
Merged
JeyJeyGao merged 2 commits intonotaryproject:mainfrom Dec 2, 2024
Merged
Conversation
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
requested review from
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT and
toddysm
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
=======================================
Coverage 80.39% 80.39%
=======================================
Files 34 34
Lines 3330 3330
=======================================
Hits 2677 2677
Misses 508 508
Partials 145 145 ☔ View full report in Codecov by Sentry. |
ghost
suggested changes
Nov 29, 2024
ghost
self-requested a review
ghost
reviewed
Nov 29, 2024
ghost
self-requested a review
shizhMSFT
changed the title
JeyJeyGao
added a commit
to JeyJeyGao/notation-go
that referenced
this pull request
Dec 9, 2024
Fix: - replaced `.String()` with the `%v` format to avoid rendering the string before actually logging it. Resolves notaryproject#480 Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
added a commit
to JeyJeyGao/notation-go
that referenced
this pull request
Dec 9, 2024
commit ecd22a2 Author: Junjie Gao <junjiegao@microsoft.com> Date: Tue Dec 3 06:19:18 2024 +0000 fix: update comment Signed-off-by: Junjie Gao <junjiegao@microsoft.com> commit 32ae375 Author: Junjie Gao <junjiegao@microsoft.com> Date: Mon Dec 2 09:10:37 2024 +0000 fix: update Signed-off-by: Junjie Gao <junjiegao@microsoft.com> commit 0076d0f Author: Junjie Gao <junjiegao@microsoft.com> Date: Mon Dec 2 03:13:08 2024 +0000 fix: update LimitedWriter Signed-off-by: Junjie Gao <junjiegao@microsoft.com> commit 067d4f6 Author: Junjie Gao <junjiegao@microsoft.com> Date: Mon Dec 2 02:32:17 2024 +0000 fix(test): update Signed-off-by: Junjie Gao <junjiegao@microsoft.com> commit 3099d35 Author: Junjie Gao <junjiegao@microsoft.com> Date: Mon Dec 2 10:03:54 2024 +0800 perf(log): encode objects only when logged (notaryproject#481) Fix: - replaced `.String()` with the `%v` format to avoid rendering the string before actually logging it. Resolves notaryproject#480 Signed-off-by: Junjie Gao <junjiegao@microsoft.com> commit 8bc331b Author: Patrick Zheng <patrickzheng@microsoft.com> Date: Mon Dec 2 08:30:56 2024 +0800 fix: enable timestamping cert chain revocation check during signing (notaryproject#482) Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> commit 161a736 Author: Junjie Gao <junjiegao@microsoft.com> Date: Mon Dec 2 02:13:35 2024 +0000 fix: resolve comments for Shiwei Signed-off-by: Junjie Gao <junjiegao@microsoft.com> commit 665e111 Author: Junjie Gao <junjiegao@microsoft.com> Date: Fri Nov 29 08:07:16 2024 +0000 fix: update code style Signed-off-by: Junjie Gao <junjiegao@microsoft.com> commit 5d6c89e Author: Junjie Gao <junjiegao@microsoft.com> Date: Fri Nov 29 08:06:15 2024 +0000 fix: update comments Signed-off-by: Junjie Gao <junjiegao@microsoft.com> commit 3bc343d Author: Junjie Gao <junjiegao@microsoft.com> Date: Fri Nov 29 07:42:38 2024 +0000 fix: update comment Signed-off-by: Junjie Gao <junjiegao@microsoft.com> commit 69303b5 Author: Junjie Gao <junjiegao@microsoft.com> Date: Fri Nov 29 07:40:15 2024 +0000 fix: limit the plugin output size Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
.String()with the%vformat to avoid rendering the string before actually logging it.Resolves #480