Skip to content

notation cert generate-test should not add to verification certs #86

@SteveLasker

Description

@SteveLasker

Current behavior:

notation cert generate-test "wabbit-networks.io"
adds the key to signingKeys and verificationCerts

{
  "enabled": false,
  "verificationCerts": {
    "certs": [
      {
        "name": "wabbit-networks.io",
        "path": "/home/stevelas/.config/notation/certificate/wabbit-networks.io.crt"
      }
    ]
  },
  "signingKeys": {
    "default": "",
    "keys": [
      {
        "name": "wabbit-networks.io",
        "path": "/home/stevelas/.config/notation/key/wabbit-networks.io.key"
      }
    ]
  },
  "insecureRegistries": []
}

Expected behavior:

Just thinking we shouldn't assume adding a signing key should imply it should immediately be verifiable. Seems the user should opt-into what they verify.

notation cert generate-test "wabbit-networks.io"
would add:

"signingKeys": {
    "default": "",
    "keys": [
      {
        "name": "wabbit-networks.io",
        "path": "/home/stevelas/.config/notation/key/wabbit-networks.io.key"
      }
    ]

Then, the user adds the key:
notation cert add "wabbit-networks.io" ~/.config/notation/certificate/wabbit-networks.io.crt
would add:

"verificationCerts": {
    "certs": [
      {
        "name": "wabbit-networks.io",
        "path": "/home/stevelas/.config/notation/certificate/wabbit-networks.io.crt"
      }
    ]

@shizhMSFT

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions