refactor!: remove blob sign/verify related contents#1011
Merged
11 commits merged intorelease-1.2from Aug 16, 2024
unknown repository
Merged
refactor!: remove blob sign/verify related contents#101111 commits merged intorelease-1.2from unknown repository
11 commits merged intorelease-1.2from
unknown repository
Conversation
added 6 commits
August 9, 2024 10:14
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
ghost
requested review from
JeyJeyGao,
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #1011 +/- ##
============================================
Coverage 72.01% 72.01%
============================================
Files 46 46
Lines 2287 2287
============================================
Hits 1647 1647
Misses 440 440
Partials 200 200 ☔ View full report in Codecov by Sentry. |
added 2 commits
August 15, 2024 14:22
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
reviewed
Aug 15, 2024
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
reviewed
Aug 15, 2024
Contributor
JeyJeyGao
left a comment
JeyJeyGao
left a comment
There was a problem hiding this comment.
LGTM. Pending on dependencies.
shizhMSFT
reviewed
Aug 15, 2024
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
ghost
mentioned this pull request
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
vaninrao10
reviewed
Aug 19, 2024
Contributor
vaninrao10
left a comment
vaninrao10
left a comment
There was a problem hiding this comment.
I see the OCI is removed in the inspect.md for the artifacts, but in policy .md we have retained the OCI artifact, dont we think there is a mismatch here "of signature verification workflow of signed OCI artifacts" ? Will it confuse the reader.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, this PR removes the blob sign/verify related contents for v1.2.0 release.
This PR targets on branch
release-1.2ONLY.