fix: add timestamping cert chain revocation check during signing#1094
Merged
6 commits merged intomainfrom Dec 6, 2024
unknown repository
Merged
fix: add timestamping cert chain revocation check during signing#10946 commits merged intomainfrom unknown repository
6 commits merged intomainfrom
unknown repository
Conversation
added 4 commits
November 21, 2024 15:41
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
ghost
requested review from
JeyJeyGao,
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1094 +/- ##
==========================================
+ Coverage 70.72% 70.79% +0.07%
==========================================
Files 47 48 +1
Lines 2948 2945 -3
==========================================
Hits 2085 2085
+ Misses 670 668 -2
+ Partials 193 192 -1 ☔ View full report in Codecov by Sentry. |
JeyJeyGao
reviewed
Dec 3, 2024
ghost
mentioned this pull request
This was referenced Mar 12, 2025
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
…aryproject#1094) Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
…aryproject#1094) Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tsa cert chain revocation check after signing to fail fast.