refactor: verify display handler by JeyJeyGao · Pull Request #1167 · notaryproject/notation

JeyJeyGao · 2025-02-07T08:01:02Z

Refactor:

move the verify command output related logic to be VerifyHandler

Example:

notation verify notationreg.azurecr.io/hello-world:v1
Warning: Always verify the artifact using digest(@sha256:...) rather than a tag(:v1) because resolved digest may not point to the same signed artifact, as tags are mutable.

Successfully verified signature for notationreg.azurecr.io/hello-world@sha256:d37ada95d47ad12224c205a938129df7a3e52345828b4fa27b03a98825d1e2e7

The artifact was signed with the following user metadata.

KEY   VALUE
foo   bar

Resolve part of #1151

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

…put_handler

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

shizhMSFT

LGTM with suggestions

cmd/notation/internal/display/output/print.go

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

cmd/notation/internal/display/metadata/interface.go

cmd/notation/internal/display/metadata/text/verify.go

cmd/notation/internal/display/metadata/interface.go

cmd/notation/internal/display/metadata/text/verify.go

cmd/notation/internal/display/metadata/interface.go

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

shizhMSFT

LGTM

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

ghost

LGTM

shizhMSFT

LGTM

@sha256

Refactor: - move the verify command output related logic to be `VerifyHandler` Example: ```sh notation verify notationreg.azurecr.io/hello-world:v1 Warning: Always verify the artifact using digest(@sha256:...) rather than a tag(:v1) because resolved digest may not point to the same signed artifact, as tags are mutable. Successfully verified signature for notationreg.azurecr.io/hello-world@sha256:d37ada95d47ad12224c205a938129df7a3e52345828b4fa27b03a98825d1e2e7 The artifact was signed with the following user metadata. KEY VALUE foo bar ``` Resolve part of notaryproject#1151 --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

@sha256

Refactor: - move the verify command output related logic to be `VerifyHandler` Example: ```sh notation verify notationreg.azurecr.io/hello-world:v1 Warning: Always verify the artifact using digest(@sha256:...) rather than a tag(:v1) because resolved digest may not point to the same signed artifact, as tags are mutable. Successfully verified signature for notationreg.azurecr.io/hello-world@sha256:d37ada95d47ad12224c205a938129df7a3e52345828b4fa27b03a98825d1e2e7 The artifact was signed with the following user metadata. KEY VALUE foo bar ``` Resolve part of notaryproject#1151 --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao added 30 commits January 16, 2025 09:21

refactor: add inpect display handler

89adf15

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update code

f0756a8

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

test: add unit test

578dea2

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

test: add e2e test for tree and json

24dea8b

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

refactor code

4031faf

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update E2E

37b967a

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: resolve comments

c2697db

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update license header

edbfbad

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update test

eb078e3

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

test: add unit test

4d3aedd

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

test: add unit test for inspect

8fdc989

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

test: update test

0640165

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: resolve comemnts

a1e411f

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: test

84a1991

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: remove envelope media type

8083c25

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: e2e test

5dd55ca

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: e2e test

25bc6a0

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update json output format

fd74cf7

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update e2e

f1c2966

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: add content type in json output

89b310f

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

test: add e2e test for invalid timestamp signature

58603ce

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update e2e test

b3a97e5

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: unit test

b108fcd

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: resolve comments

721518a

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: resolve comments

0997875

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

refactor: display package structure

aef5735

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update to use *ocispec.Descriptor

5b28eda

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: restore package structure

8f5d88f

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: restore "NewInpsectHandler" function name

1adc392

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: move internal/tree to tree handlers package

da16190

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao added 2 commits February 8, 2025 04:52

Merge remote-tracking branch 'upstream/main' into refactor/verify_out…

7b4961f

…put_handler

fix: update code

a029bd2

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao marked this pull request as ready for review February 8, 2025 05:04

JeyJeyGao requested review from NiazFK, gokarnm, priteshbandi, rgnote, shizhMSFT and toddysm as code owners February 8, 2025 05:04

JeyJeyGao requested a review from a user February 8, 2025 05:04

JeyJeyGao requested review from vaninrao10 and yizha1 as code owners February 8, 2025 05:04

JeyJeyGao mentioned this pull request Feb 8, 2025

housekeeping: refactoring for sustainable coding #1151

Closed

5 tasks

shizhMSFT previously approved these changes Feb 8, 2025

View reviewed changes

cmd/notation/internal/display/output/print.go Outdated Show resolved Hide resolved

fix: resolve comment

1f6e1c0

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao dismissed shizhMSFT’s stale review via 1f6e1c0 February 8, 2025 15:05

ghost reviewed Feb 10, 2025

View reviewed changes

fix: resolve comments

e33dc04

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

shizhMSFT previously approved these changes Feb 10, 2025

View reviewed changes

fix: add an empty line between warning and final message

0485b7f

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao dismissed shizhMSFT’s stale review via 0485b7f February 11, 2025 02:07

JeyJeyGao requested a review from a user February 11, 2025 02:28

ghost approved these changes Feb 11, 2025

View reviewed changes

shizhMSFT approved these changes Feb 11, 2025

View reviewed changes

JeyJeyGao merged commit 73b1551 into notaryproject:main Feb 11, 2025
7 checks passed

JeyJeyGao deleted the refactor/verify_output_handler branch February 11, 2025 05:50

This was referenced Mar 12, 2025

bump: release v2.0.0-alpha.1 #1215

Closed

bump: release v2.0.0-alpha.1 #1218

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor: verify display handler#1167

refactor: verify display handler#1167
JeyJeyGao merged 39 commits intonotaryproject:mainfrom
JeyJeyGao:refactor/verify_output_handler

JeyJeyGao commented Feb 7, 2025 •

edited

Loading

Uh oh!

shizhMSFT left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shizhMSFT left a comment

Uh oh!

ghost left a comment

Uh oh!

shizhMSFT left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

JeyJeyGao commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JeyJeyGao commented Feb 7, 2025 •

edited

Loading