Skip to content

Comments

fix: blob policy command messages with docs#1175

Merged
JeyJeyGao merged 13 commits intonotaryproject:mainfrom
JeyJeyGao:fix/blob_policy_docs
Feb 21, 2025
Merged

fix: blob policy command messages with docs#1175
JeyJeyGao merged 13 commits intonotaryproject:mainfrom
JeyJeyGao:fix/blob_policy_docs

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Feb 17, 2025

Fix:

  • simplified blob policy show codes
  • improved help docs and error messages
  • improved docs
  • printed imported blob trust policy file path

Resolves #1134

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao changed the title fix: blob policy command with docs fix: blob policy command messages with docs Feb 17, 2025
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.99%. Comparing base (af97fb4) to head (70bf565).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/notation/blob/policy/import.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
- Coverage   76.03%   75.99%   -0.05%     
==========================================
  Files          69       69              
  Lines        3610     3603       -7     
==========================================
- Hits         2745     2738       -7     
  Misses        669      669              
  Partials      196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao marked this pull request as ready for review February 17, 2025 06:00
@JeyJeyGao JeyJeyGao requested a review from a user February 17, 2025 06:00
shizhMSFT
shizhMSFT previously approved these changes Feb 17, 2025
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 76936ad into notaryproject:main Feb 21, 2025
7 checks passed
@JeyJeyGao JeyJeyGao deleted the fix/blob_policy_docs branch February 21, 2025 01:47
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Fix:
- simplified `blob policy show` codes
- improved help docs and error messages
- improved docs
- printed imported blob trust policy file path

Resolves notaryproject#1134

---------

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Fix:
- simplified `blob policy show` codes
- improved help docs and error messages
- improved docs
- printed imported blob trust policy file path

Resolves notaryproject#1134

---------

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update blob spec

2 participants