chore: move common flags to cmd package#1195
Merged
JeyJeyGao merged 3 commits intonotaryproject:mainfrom Mar 6, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1195 +/- ##
=======================================
Coverage 76.22% 76.22%
=======================================
Files 71 70 -1
Lines 3634 3634
=======================================
Hits 2770 2770
Misses 668 668
Partials 196 196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JeyJeyGao
changed the title
option package
JeyJeyGao
changed the title
option packageoption package
JeyJeyGao
requested review from
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT and
toddysm
as code owners
JeyJeyGao
changed the title
option packageoption package
5 tasks
shizhMSFT
reviewed
Feb 27, 2025
ghost
suggested changes
Feb 28, 2025
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
force-pushed
the
fix/flags_to_option
branch
from
33e290e to
cf3da64
Compare
JeyJeyGao
changed the title
option packagecmd package
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
This was referenced Mar 12, 2025
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
Moved `cmd/notation/common.go` to `cmd` package to concentrate all the flags and options related code in one place. --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
Moved `cmd/notation/common.go` to `cmd` package to concentrate all the flags and options related code in one place. --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved
cmd/notation/common.gotocmdpackage to concentrate all the flags and options related code in one place.