Skip to content

Comments

feat: blob policy init command#1196

Merged
JeyJeyGao merged 16 commits intonotaryproject:mainfrom
JeyJeyGao:feat/blob_policy_init
Mar 11, 2025
Merged

feat: blob policy init command#1196
JeyJeyGao merged 16 commits intonotaryproject:mainfrom
JeyJeyGao:feat/blob_policy_init

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Feb 27, 2025

This PR implements #1197

Feat:

  • added blob policy init comamnd

Docs:

  • fixed the blob-signing.md spec

Test:

  • added E2E

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 86.95652% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.33%. Comparing base (d340541) to head (4f1c92a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/notation/blob/policy/init.go 86.76% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1196      +/-   ##
==========================================
+ Coverage   76.13%   76.33%   +0.20%     
==========================================
  Files          66       67       +1     
  Lines        3628     3697      +69     
==========================================
+ Hits         2762     2822      +60     
- Misses        669      675       +6     
- Partials      197      200       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao marked this pull request as ready for review March 4, 2025 06:17
@JeyJeyGao JeyJeyGao requested a review from a user March 4, 2025 06:17
shizhMSFT
shizhMSFT previously approved these changes Mar 4, 2025
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the refactoring PR #1205 to be done, just in case there's any additional changes in this PR.

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 167bfd4 into notaryproject:main Mar 11, 2025
7 checks passed
@JeyJeyGao JeyJeyGao deleted the feat/blob_policy_init branch March 11, 2025 01:41
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
This PR implements notaryproject#1197 

Feat:
- added `blob policy init` comamnd

Docs:
- fixed the `blob-signing.md` spec

Test:
- added E2E

---------

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
This PR implements notaryproject#1197 

Feat:
- added `blob policy init` comamnd

Docs:
- fixed the `blob-signing.md` spec

Test:
- added E2E

---------

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants