Merged
Conversation
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
requested changes
Mar 12, 2025
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the reference to the go.mod module for the notation project from github.com/notaryproject/notation to github.com/notaryproject/notation/v2. The changes update the import paths across various packages such as blob commands, certificate commands, display handlers, policy imports, and tests.
- Updated import paths for multiple packages to use the new v2 module.
- Adjusted references in command files, internal display packages, tests, and policy imports.
Reviewed Changes
Copilot reviewed 59 out of 59 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/notation/blob/cmd.go | Updated blob policy import to v2 |
| cmd/notation/internal/display/metadata/json/inspect.go | Updated output import to v2 |
| cmd/notation/cert/add.go | Updated truststore import to v2 |
| cmd/notation/blob/verify.go | Updated imports for display, flag, verify, and envelope to v2 |
| cmd/notation/cert/delete.go | Updated truststore import to v2 |
| cmd/notation/inspect.go | Updated imports for display, errors, and flag to v2 |
| cmd/notation/blob/inspect.go | Updated imports for display, output, and flag to v2 |
| cmd/notation/blob/sign_test.go | Updated flag and envelope imports to v2 |
| cmd/notation/internal/display/metadata/text/blobverify.go | Updated display output import to v2 |
| cmd/notation/internal/display/handler.go | Updated metadata and output imports to v2 |
| cmd/notation/inspect_test.go | Updated display output and flag imports to v2 |
| cmd/notation/blob/policy/import.go | Updated display and osutil imports to v2 |
| cmd/notation/internal/display/metadata/json/blob_inspect.go | Updated output import to v2 |
| cmd/notation/cert/generateTest.go | Updated truststore and osutil imports to v2 |
| cmd/notation/cert/show.go | Updated flag and truststore imports to v2 |
| cmd/notation/blob/sign.go | Updated imports for display, flag, sign, envelope, httputil, osutil, revocation, and x509 to v2 |
| cmd/notation/cert/list.go | Updated flag and truststore imports to v2 |
| cmd/notation/blob/policy/init.go | Updated display, output, and osutil imports to v2 |
| cmd/notation/internal/display/metadata/json/inspect_helper.go | Updated envelope import to v2 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1216 +/- ##
=======================================
Coverage 76.46% 76.46%
=======================================
Files 67 67
Lines 3696 3696
=======================================
Hits 2826 2826
Misses 671 671
Partials 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps up go.mod module to
github.com/notaryproject/notation/v2.