Skip to content

Comments

bump: bump up go.mod module#1216

Merged
2 commits merged intomainfrom
unknown repository
Mar 12, 2025
Merged

bump: bump up go.mod module#1216
2 commits merged intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Mar 12, 2025

This PR bumps up go.mod module to github.com/notaryproject/notation/v2.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
JeyJeyGao previously approved these changes Mar 12, 2025
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested review from JeyJeyGao and shizhMSFT March 12, 2025 08:34
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT requested a review from Copilot March 12, 2025 08:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the reference to the go.mod module for the notation project from github.com/notaryproject/notation to github.com/notaryproject/notation/v2. The changes update the import paths across various packages such as blob commands, certificate commands, display handlers, policy imports, and tests.

  • Updated import paths for multiple packages to use the new v2 module.
  • Adjusted references in command files, internal display packages, tests, and policy imports.

Reviewed Changes

Copilot reviewed 59 out of 59 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cmd/notation/blob/cmd.go Updated blob policy import to v2
cmd/notation/internal/display/metadata/json/inspect.go Updated output import to v2
cmd/notation/cert/add.go Updated truststore import to v2
cmd/notation/blob/verify.go Updated imports for display, flag, verify, and envelope to v2
cmd/notation/cert/delete.go Updated truststore import to v2
cmd/notation/inspect.go Updated imports for display, errors, and flag to v2
cmd/notation/blob/inspect.go Updated imports for display, output, and flag to v2
cmd/notation/blob/sign_test.go Updated flag and envelope imports to v2
cmd/notation/internal/display/metadata/text/blobverify.go Updated display output import to v2
cmd/notation/internal/display/handler.go Updated metadata and output imports to v2
cmd/notation/inspect_test.go Updated display output and flag imports to v2
cmd/notation/blob/policy/import.go Updated display and osutil imports to v2
cmd/notation/internal/display/metadata/json/blob_inspect.go Updated output import to v2
cmd/notation/cert/generateTest.go Updated truststore and osutil imports to v2
cmd/notation/cert/show.go Updated flag and truststore imports to v2
cmd/notation/blob/sign.go Updated imports for display, flag, sign, envelope, httputil, osutil, revocation, and x509 to v2
cmd/notation/cert/list.go Updated flag and truststore imports to v2
cmd/notation/blob/policy/init.go Updated display, output, and osutil imports to v2
cmd/notation/internal/display/metadata/json/inspect_helper.go Updated envelope import to v2

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 6ddc128 into notaryproject:main Mar 12, 2025
5 checks passed
@ghost ghost deleted the upgrade branch March 12, 2025 08:46
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.46%. Comparing base (7d8e4e1) to head (9785b4e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1216   +/-   ##
=======================================
  Coverage   76.46%   76.46%           
=======================================
  Files          67       67           
  Lines        3696     3696           
=======================================
  Hits         2826     2826           
  Misses        671      671           
  Partials      199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ghost ghost mentioned this pull request Mar 12, 2025
6 tasks
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants