Skip to content

Comments

fix: add os/arch in version command#1275

Merged
JeyJeyGao merged 2 commits intonotaryproject:mainfrom
JeyJeyGao:fix/version
May 13, 2025
Merged

fix: add os/arch in version command#1275
JeyJeyGao merged 2 commits intonotaryproject:mainfrom
JeyJeyGao:fix/version

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented May 12, 2025

Pending on #1260

Example of notation version command

Notation - a tool to sign and verify artifacts.

Version:     v2.0.0-alpha.1+unreleased
Go version:  go1.24.0
OS/Arch:     linux/amd64
Git commit:  c68425f82871c27140a5c1b259b518750e558446

Resolve part of #1247

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.97%. Comparing base (c68425f) to head (006e823).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1275   +/-   ##
=======================================
  Coverage   76.96%   76.97%           
=======================================
  Files          68       68           
  Lines        3847     3848    +1     
=======================================
+ Hits         2961     2962    +1     
  Misses        682      682           
  Partials      204      204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeyJeyGao JeyJeyGao requested a review from Copilot May 12, 2025 07:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the version command to include OS/Arch information in the output.

  • Added a new line to print the OS/Arch using runtime.GOOS and runtime.GOARCH.
  • Maintains consistency with existing version output.

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 083e73d into notaryproject:main May 13, 2025
7 checks passed
@JeyJeyGao JeyJeyGao deleted the fix/version branch May 13, 2025 05:28
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Pending on notaryproject#1260

Example of notation version command
```
Notation - a tool to sign and verify artifacts.

Version:     v2.0.0-alpha.1+unreleased
Go version:  go1.24.0
OS/Arch:     linux/amd64
Git commit:  c68425f
```

Resolve part of notaryproject#1247

---------

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants