fix!: remove the --verbose flag for all related commands#1276
Merged
JeyJeyGao merged 3 commits intonotaryproject:mainfrom May 13, 2025
Merged
fix!: remove the --verbose flag for all related commands#1276JeyJeyGao merged 3 commits intonotaryproject:mainfrom
JeyJeyGao merged 3 commits intonotaryproject:mainfrom
Conversation
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
requested review from
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT and
toddysm
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for the --verbose flag in favor of the existing --debug flag. The changes update the documentation for error handling and command usage, and remove the verbose flag references from both CLI specifications and internal flag configuration.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| specs/error-handling-guideline.md | Updated error troubleshooting guidance to refer to --debug instead of --verbose. |
| specs/cmd/*.md | Removed the --verbose flag from various command specifications. |
| cmd/notation/internal/flag/options.go | Eliminated the verbose flag and its usage from logger configuration. |
Comments suppressed due to low confidence (2)
specs/error-handling-guideline.md:33
- The update to use '--debug' instead of '--verbose' is clear; please verify that all related help text and user guidance across the commands are updated accordingly.
- If the error message is not enough for troubleshooting, guide users to use `--verbose` to print much more detailed logs.
cmd/notation/internal/flag/options.go:62
- Ensure that the removal of the '--verbose' flag and its corresponding logger level configuration does not impact existing behavior or backward compatibility; also, update any related tests and documentation.
fs.BoolVarP(&opts.Verbose, "verbose", "v", false, "verbose mode")
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
changed the title
JeyJeyGao
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
- Coverage 76.96% 76.95% -0.02%
==========================================
Files 68 68
Lines 3847 3844 -3
==========================================
- Hits 2961 2958 -3
Misses 682 682
Partials 204 204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
…ct#1276) Pending on notaryproject#1260 This PR removed the `--verbose` flag support as proposed in notaryproject#1260. Resolve part of notaryproject#1247 --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending on #1260
This PR removed the
--verboseflag support as proposed in #1260.Resolve part of #1247