Add plugin sign capabaility#176
Merged
SteveLasker merged 16 commits intonotaryproject:mainfrom May 19, 2022
Merged
Conversation
5 tasks
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
gokarnm
requested changes
May 19, 2022
Co-authored-by: Milind Gokarn <milind81@gmail.com> Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
gokarnm
approved these changes
May 19, 2022
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
* support plugin keys Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * update plugins branch Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * implement plugin signing Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * pass PluginConfig Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * bump notation-go Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * upgrade notation-go Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * upgrade notation-go Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * bump notation-go Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * revert name change Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * remove unnecessary casts Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * remove unnecessary casts Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * simplify isDefaultKey Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * revert unnecessary change Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * support config maps Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * switch to notaryproject/notation-go@main Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> * Apply suggestions from code review Co-authored-by: Milind Gokarn <milind81@gmail.com> Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> Co-authored-by: Milind Gokarn <milind81@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for using external keys to sign images with the plugins.