Registry Authentication Spec#192
Merged
shizhMSFT merged 8 commits intonotaryproject:mainfrom Jun 21, 2022
Merged
Conversation
shizhMSFT
force-pushed
the
auth
branch
3 times, most recently
from
db8e897 to
a2bf3e9
Compare
michaelb990
reviewed
Jun 9, 2022
michaelb990
left a comment
michaelb990
left a comment
There was a problem hiding this comment.
Overall, this looks pretty good. Just to make sure I'm not missing something, does this proposal diverge from how auth works when using Docker to authenticate with a registry? And if so, how/why?
Important things to confirm (maybe others):
- config file is at the same path
s/docker/notation, but can be basically identical - credential helpers work the same as in docker (with an implied
docker-credentialprefix on the binary tool)
gokarnm
reviewed
Jun 13, 2022
michaelb990
approved these changes
Jun 14, 2022
Contributor
|
@SteveLasker @sajayantony do you want to review this PR? |
gokarnm
requested changes
Jun 16, 2022
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
gokarnm
reviewed
Jun 21, 2022
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #119
Signed-off-by: Shiwei Zhang shizh@microsoft.com