Remove credential file from spec#262
Merged
shizhMSFT merged 1 commit intonotaryproject:mainfrom Aug 3, 2022
Merged
Conversation
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
binbin-li
reviewed
Aug 1, 2022
| ## Credential Store | ||
|
|
||
| As local credentials may be required to access the remote registries, they need to be stored and accessed securely. To achieve maximum security, credential helpers are preferred so that credentials are stored in the system key chain with better protection. If credential helpers are not available, notation will fall back to credential files with proper access control. | ||
| As local credentials may be required to access the remote registries, they need to be stored and accessed securely. To achieve maximum security, credential helpers are preferred so that credentials are stored in the system key chain with better protection. If credential helpers are not available, credentials SHOULD be provided to notation via command line parameters `--username` / `--password` or environment variables `NOTATION_USERNAME` / `NOTATION_PASSWORD`. |
Contributor
There was a problem hiding this comment.
username/password options are only supported in notation loging cmd now. Should we mention it here?
Contributor
There was a problem hiding this comment.
Yes, we need to clarify what is or is not supported.
Contributor
Author
There was a problem hiding this comment.
username/password options are also supported for notation sign, notation verify, and other commands which need registry accesses.
gokarnm
approved these changes
Aug 2, 2022
Member
|
Do we need to create another issue to update the CLI baseline accordingly? |
Contributor
Yeah, I'll create an issue to track it. Current implementation does support username/password options in other commands. We can just update the cli spec. |
FeynmanZhou
approved these changes
Aug 2, 2022
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #206