fixed the hello-signing workflow with self-generated certificate chain#264
Merged
shizhMSFT merged 9 commits intonotaryproject:mainfrom Aug 4, 2022
Merged
Conversation
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
chloeyin
reviewed
Jul 26, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Contributor
|
LGTM |
binbin-li
reviewed
Jul 27, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
binbin-li
reviewed
Jul 27, 2022
Contributor
|
lgtm |
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 50.00% 50.00%
=======================================
Files 11 11
Lines 344 344
=======================================
Hits 172 172
Misses 164 164
Partials 8 8 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Contributor
|
Per the PR review criteria @notaryproject/notation-sub-group-maintainers - this is past a week old and has two approvals from official code-reviewers, so it is eligible for merge now. @binbin-li and @JeyJeyGao - much appreciate if you can officially approve the PR versus just a LGTM for all PRs moving forward. |
binbin-li
approved these changes
Aug 4, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
notaryproject#264) Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Zheng patrickzheng@microsoft.com
Tested with the workflow mentioned in hello-signing
Resolves #259